Add newly boards (Deneyap Kart 1A v2, Deneyap Mini v2) #7603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zeynepdicle , I saw some recent changes in previous closed PR. Are these changes final for now? :) |
Hi @P-R-O-C-H-Y , Yes these are final changes :) |
P-R-O-C-H-Y
requested changes
Dec 21, 2022
There was a problem hiding this comment.
Hi @zeynepdicle, please take a look on my comments :) once everything is fixed it can be merged 👍
P-R-O-C-H-Y
added
the
Resolution: Awaiting response
|
Hi again @P-R-O-C-H-Y :) I fixed it, any problem? |
P-R-O-C-H-Y
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
@zeynepdicle Thanks for quick fixes :) Will merge after CI passes.
@P-R-O-C-H-Y thank you too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add newly boards
Update pin_arduino.h and boardds.txt files for Deneyap Boards
Tests scenarios
I have tested my Pull Request on Arduino-esp32 core v2.0.5 v2.0.4 with ESP32 and Deneyap-Arduino-core v1.3.9 with this scenarios.
Related links
Official website: https://deneyapkart.org/en/
Documents: https://docs.deneyapkart.org/en/
Forum: https://forum.deneyapkart.org/
Github: https://github.com/deneyapkart
(eg. Closes #number of issue)